14 replies to this topic

[k1000o]

Hello

I've trying to install the version 0.6.5, but during the install the following error occurs

SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'serializeddata' at row 1

After some investigation I found that the auditevent event table is created with the field serializeddata as VARCHAR(255), if we change it to TEXT the installation works fine.

How can we force the creation of this field as TEXT?

[Jason]

Strange. It is declared the same way in GlobalMetadata model, and that serializedMetadata is correctly formed as Text in the database. I will investigate and let you know what i find

[Jason]

This will be in the release for this upcoming week. However if you look here:
http://hg.zurmo.org/...et/47d85ab204da
You can easily make this change locally. Please let us know if it works. Also check the About page in the app

[k1000o]

The error still appears in this version. It's really strange and I cannot find the issue.
As a workaround only to finish the installation we can change the method protected->modules->zurmo-models->AuditEvent->logAuditEvent as specified below. Doing this change the table have the column as TEXT and the application works.

		public static function logAuditEvent($moduleName, $eventName, $data = null, RedBeanModel $model = null, User $user = null)
		{
			assert('is_string($moduleName) && $moduleName != ""');
			assert('is_string($eventName)  && $eventName  != ""');
			if ($user === null)
			{
				$user = Yii::app()->user->userModel;
				if (!$user instanceof User)
				{
					throw new NoCurrentUserSecurityException();
				}
			}
			if (!AuditEvent::$isTableOptimized && (!AUDITING_OPTIMIZED || !RedBeanDatabase::isFrozen()))
			{
				$tableName  = self::getTableName('AuditEvent');
				RedBean_Plugin_Optimizer_Id::ensureIdColumnIsINT11($tableName, strtolower('modelId'));
				$auditEvent = new AuditEvent();
				$auditEvent->dateTime	   = DateTimeUtil::convertTimestampToDbFormatDateTime(time());
				$auditEvent->moduleName	 = $moduleName;
				$auditEvent->eventName	  = $eventName;
				$auditEvent->user		   = $user;
				$auditEvent->modelClassName = $model !== null ? get_class($model) : null;
				$auditEvent->modelId		= $model !== null ? $model->id		: null;
				$auditEvent->serializedData = serialize($data);
				$saved = $auditEvent->save();
				AuditEvent::$isTableOptimized = true;
			}
			else
			{
				$sql = "insert into auditevent (datetime,
												modulename,
												eventname,
												_user_id,
												modelclassname,
												modelid
												)
						values ('" . DateTimeUtil::convertTimestampToDbFormatDateTime(time()) . "',
								'$moduleName',
								'$eventName',
								{$user->id}, " .
								($model !== null ? "'" . get_class($model) . "', " : 'null, ') .
								($model !== null ? "{$model->id}, "				 : 'null, ') .
								":data)";
				
				$saved = true;
			}
			return $saved;
		}

[Jason]

Did you try to apply the change i made in bitbucket? You are saying it was still broken even with that change?

[k1000o]

I cloned the repository and checked the ZurmoModule.php file as described but the error persists. The strange thing is that if the logAuditEvent function is not modified as described above the serializeddata column is generated as VARCHAR 255 and the following error appears.

SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'serializeddata' at row 1

C:\inetpub\wwwroot\zurmo\redbean\rb.php(902)

890 $s->execute();
891 }
892 $this->affected_rows=$s->rowCount();
893 return $this->affected_rows;
894 }
895 catch(PDOException $e) {

[Jason]

Strange. We can't just remove the execution line in logAuditEvent. I am wondering what sql_mode is your MySQL configuration? I am thinking there is something with your MySQL configuration that we have not encountered before. Also on line 101, $saved, is that ever false? can you check if it is false at all and throw an exception?

[Jason]

Did you put AuditEvent as the first entry in getRootModelNames() ?

[Sacha Telgenhof]

Jason, I had a similar issue on serialized data from the audit table. I was using different Zurmo versions with the same database... I know, not a good idea but I got around the issue by removing some of the audit table entries. Of course the best thing is to start with a clean database

[k1000o]

Here it's the sql-mode

# Set the SQL mode to strict
sql-mode="STRICT_TRANS_TABLES,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"

and yes AuditEvent is the first entry in getRootModelNames()

	public function getRootModelNames() {
		// ZurmoModule is a special case in that most of its models
		// are non-root models of things that root models in the other
		// modules, and because ZurmoModule is the root of the module
		// dependence hierarchy it needed concern itself, other than
		// with the models that are specific to itself.
		return array('AuditEvent', 'NamedSecurableItem', 'GlobalMetadata', 'PerUserMetadata', 'Portlet', 'CustomFieldData',
			'CalculatedDerivedAttributeMetadata', 'DropDownDependencyDerivedAttributeMetadata');
	}

[Jason]

Ok i think I know what is going on. If you go into RedBeanDatabaseBuilderUtil.php, and in the function autoBuildModels, what you need to do is make the AuditEvent the first entry in the array $modelClassNames that is coming in as a parameter. I believe that the auditEvent model needs to be created first.

If you can test manipulating the $modelClassNames array right in the beginning of the method, to have AuditEvent first, then let me know if it still breaks. We can go from there.

Actually now that I think about it, can you send the complete output as an attachment. I want to see where this error comes in the autobuild process. Is it in the beginning of the auto build process or later?

[k1000o]

If we modify RedBeanDatabaseBuilderUtil.php->autoBuildModels as below the installation works fine

..............................
self::$uniqueStrings = array();

 
        if (in_array('AuditEvent', $modelClassNames)) {
            unset($modelClassNames[array_search('AuditEvent', $modelClassNames)]);
            array_unshift($modelClassNames, "AuditEvent");
        }

foreach ($modelClassNames as $modelClassName) {
.................................

[Jason]

Fixed
https://www.pivotalt...y/show/29936051
http://hg.zurmo.org/...et/e05ae1e0ae94

Please let me know if it works ok, my fix.

[k1000o]

Yes it works, thanks.....

[Jason]

Great. Thanks for figuring it out.